https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7211

--- Comment #22 from Bernhard Schmidt <[email protected]> ---
(In reply to Henrik Krohns from comment #21)
> Implemented asn_lookup_ipv6 with some code cleanups/fixes.
> 
> Sending        spamassassin-3.4/UPGRADE
> Sending        spamassassin-3.4/lib/Mail/SpamAssassin/Plugin/ASN.pm
> Sending        spamassassin-3.4/t/cross_user_config_leak.t
> Sending        trunk/UPGRADE
> Sending        trunk/lib/Mail/SpamAssassin/Plugin/ASN.pm
> Sending        trunk/rules/25_asn.cf
> Sending        trunk/t/cross_user_config_leak.t
> Transmitting file data .......done
> Committing transaction...
> Committed revision 1857549.

Thanks a lot! I have tested your patch and it works fine, I'm currently
building a package to propose it to Debian. However I have a few questions
about your updated 25_asn.cf

1.) Is there a reason the updated rule is not in the 3.4 branch (I honestly
don't know whether rules are always in trunk regardless of the version, if yes
please ignore this comment)
2.) Is there a reason it is commented out by default? The conditional should
take care of versions not supporting it
3.) I think it should be asn_lookup_ipv6 inside the if-block

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to