https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7723
Bug ID: 7723
Summary: [review] FromNameSpoof warnings with missing To-header
Product: Spamassassin
Version: 3.4.2
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Plugins
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: Undefined
Ugly warnings if message missing To: header (many legit mails in my corpus).
warn: Use of uninitialized value $toaddrs[0] in lc at
Mail/SpamAssassin/Plugin/FromNameSpoof.pm line 366.
warn: Use of uninitialized value $owner in string ne at
Mail/SpamAssassin/Plugin/FromNameSpoof.pm line 425.
warn: Use of uninitialized value $2 in string ne at
Mail/SpamAssassin/Plugin/FromNameSpoof.pm line 425.
warn: Use of uninitialized value $owner in pattern match (m//) at
Mail/SpamAssassin/Plugin/FromNameSpoof.pm line 429.
Honestly the overall code flow / state machine could use quite a bit of
polishing, there's repeated _check_fromnamespoof calls doing duplicate stuff
from every eval function and the function itself seems to be returning randomly
from different points. I'd rather leave sorting this out to Paul. ;-)
For 3.4.3 perhaps just add below change and don't risk breaking other stuff,
for RTC please vote to commit (I say +1)
my @toaddrs = $pms->all_to_addrs();
+ return 0 unless @toaddrs;
--
You are receiving this mail because:
You are the assignee for the bug.
