+1 to the crazy bit, it's something I've realised over the weeks of looking into the mass check.
With reuse flag on masscheck the X-Spam headers are used to generate the corpus submission - subrules aren't output in this header so they're not submitted. I'm not certain how to fix without requiring full rule list in headers - this causes problems across multiple SA instances and versions - Amavis etc On Wed, 3 Jul 2019 at 11:30, Henrik Krohns <[email protected]> wrote: > > There's also some strange dependency for autolearning in Conf.pm functions > maybe_header_only, maybe_body_only (who came up with the function names? > so > vague). It seems net flagged metas are ignored for auto-learn scoring. > Dunno if this is good or bad, more stuff to investigate.. > > Cc'ing dev > > On Wed, Jul 03, 2019 at 01:26:11PM +0300, Henrik Krohns wrote: > > > > That should be considered a bug then. > > > > Probably metas should inherit all the flags from rules they use, it's > crazy > > to start flagging all meta rules manually. > > > > On Wed, Jul 03, 2019 at 11:21:02AM +0100, Paul Stead wrote: > > > On the weekly mass check when --reuse is used subrules are not > submitted. This > > > means if no reuse on the full rule it'll be ignored during a --reuse > run > > > because the subrule isn't submitted. > > > > > > On Wed, 3 Jul 2019 at 11:10, Henrik Krohns <[1][email protected]> wrote: > > > > > > > > > also no need to reuse PDS_HP_HELO_NORDNS, metas do not launch > network > > > rules. > > > Reuse needs to be on the actual query launching rule. > > > > > > On Wed, Jul 03, 2019 at 01:09:19PM +0300, Henrik K wrote: > > > > > > > > > > > > __HELO_RECORD needs to be reuse, not PDS_NO_HELO_DNS > > > > > > > > > > > > On Wed, Jul 03, 2019 at 10:04:41AM -0000, [2][email protected] > wrote: > > > > > Author: pds > > > > > Date: Wed Jul 3 10:04:41 2019 > > > > > New Revision: 1862459 > > > > > > > > > > URL: [3]http://svn.apache.org/viewvc?rev=1862459&view=rev > > > > > Log: > > > > > These depend on net > > > > > > > > > > Modified: > > > > > spamassassin/trunk/rulesrc/sandbox/pds/[4]20_helo.cf > > > > > > > > > > Modified: spamassassin/trunk/rulesrc/sandbox/pds/[5]20_helo.cf > > > > > URL: [6] > http://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox > > > /pds/20_helo.cf?rev=1862459&r1=1862458&r2=1862459&view=diff > > > > > > ======================================================================= > > > ======= > > > > > --- spamassassin/trunk/rulesrc/sandbox/pds/[7]20_helo.cf > (original) > > > > > +++ spamassassin/trunk/rulesrc/sandbox/pds/[8]20_helo.cf Wed > Jul 3 > > > 10:04:41 2019 > > > > > @@ -3,20 +3,24 @@ header __HELO_HIGHPROFILE X-Spam-Rela > > > > > meta PDS_HELO_SPF_FAIL SPF_HELO_FAIL && __HELO_HIGHPROFILE > > > > > describe PDS_HELO_SPF_FAIL High profile HELO that fails SPF > > > > > score PDS_HELO_SPF_FAIL 2.0 > > > > > +tflags PDS_HELO_SPF_FAIL net > > > > > reuse PDS_HELO_SPF_FAIL > > > > > > > > > > meta PDS_HP_HELO_NORDNS RDNS_NONE && __HELO_HIGHPROFILE > > > > > describe PDS_HP_HELO_NORDNS High profile HELO with no sender > rDNS > > > > > score PDS_HP_HELO_NORDNS 1.0 > > > > > +tflags PDS_HP_HELO_NORDNS net > > > > > reuse PDS_HP_HELO_NORDNS > > > > > > > > > > ifplugin Mail::SpamAssassin::Plugin::AskDNS > > > > > > > > > > askdns __HELO_RECORD _LASTEXTERNALHELO_ A /./ > > > > > +tflags __HELO_RECORD net > > > > > > > > > > meta PDS_NO_HELO_DNS (__HELO_HIGHPROFILE && > !__HELO_RECORD) > > > > > describe PDS_NO_HELO_DNS High profile HELO but no A record > > > > > score PDS_NO_HELO_DNS 2.0 > > > > > +tflags PDS_NO_HELO_DNS net > > > > > reuse PDS_NO_HELO_DNS > > > > > > > > > > endif > > > > > > > > > > > > > > References: > > > > > > [1] mailto:[email protected] > > > [2] mailto:[email protected] > > > [3] http://svn.apache.org/viewvc?rev=1862459&view=rev > > > [4] http://20_helo.cf/ > > > [5] http://20_helo.cf/ > > > [6] > http://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/pds/20_helo.cf?rev=1862459&r1=1862458&r2=1862459&view=diff > > > [7] http://20_helo.cf/ > > > [8] http://20_helo.cf/ >
