On Thu, 16 Jan 2020, Michael Peddemors wrote:

Eg, we use __LM and __MM depending on what platform the rules are meant to be for..

However, maybe we 'should' consider ways for standardizing naming conventions, eg for any one building private rule sets for distribution.. eg, if one of our customer decided to also add someone else's private rule sets, and the person happened to be named 'Mighty Mouse'..

If an idea does surface, it should be good for all cases.

Long term, suggest that we build in something to the actual naming conventions somehow, that if it comes from anything other than the base upstream, somehow it gets auto_prefixed.. Just throwing the idea out.

The problem with auto-prefixing is it prevents *intentional* override of the base rules.

Is there a reliable way to distinguish between base rules and local rules? Using the path to the config file seems fragile...


On 2020-01-16 12:43 p.m., Kevin A. McGrail wrote:
I would recommend local rules are named based on your initials.  That's been the collision avoidance for nearly 2 decades.  Does that not solve the issue at hand?

On Thu, Jan 16, 2020, 14:53 John Hardin <[email protected] <mailto:[email protected]>> wrote:

    On Thu, 16 Jan 2020, RW wrote:

     > On Thu, 16 Jan 2020 17:37:48 +0200
     > Henrik K wrote:
     >
     >> On Thu, Jan 16, 2020 at 03:03:40PM +0000, RW wrote:
     >>>
>>>> It would seem more productive to actually make spamassassin --lint
     >>>> output info messages (not errors) when rules are redefined.  And
     >>>> perhaps add a new tflag "redefine" (suggestions?) to suppress
     >>>> those warnings for intentional redefines.
     >>>
     >>> That requires actual coding, and it only partially works.
     >>>
     >>> Let's say I have local rules:
     >>>
     >>> body  __FOO ...
     >>> meta  FOO   __FOO ...
     >>> score FOO  0.001
     >>>
     >>> and then in the middle of the night sa-learn downloads new rules:
     >>>
     >>> header  __FOO ...
     >>> meta    BAR   __FOO ...
     >>> score   BAR  3.0
     >>>
     >>> My high-FP informational version of __FOO then gets used in
    place of
     >>> the core version in a high scoring meta rule.
     >>
     >> And --lint would say
     >>
     >> Notice: rule __FOO redefined, check what's going on or use tflags
     >> redefine
     >
     > And that would only be noticed after the FPs.

    +1


--
 John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
 [email protected]    FALaholic #11174     pgpk -a [email protected]
 key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
  Judicial Activism (n): interpreting the Constitution to grant the
  government powers that are popularly felt to be "needed" but that
  are not explicitly provided for therein (common definition);
  interpreting the Constitution as it is written (Brady definition)
-----------------------------------------------------------------------
 Tomorrow: Benjamin Franklin's 314th Birthday

Reply via email to