On 4/20/20 4:22 PM, Henrik K wrote:
>
> DKIM check is not async, so simply use priority for eval order? This is
> what AWL/TxRep already do, running at prio 1000, DKIM is done by then..
>
running at prio 1000 doesn't work for DKIM, a debug run always ends with "dbg:
check: tagrun - tag DKIMDOMAIN is still blocking action 0, 2, 4, ..."
> Of course more elegant solution could be designed, but it would require
> rewriting lot of plugins..
>
>
> On Mon, Apr 20, 2020 at 03:50:52PM +0200, Giovanni Bechis wrote:
>> Hi,
>> for something I am working on I need a dependency between my new code and
>> DKIM.
>> DKIM sets a tag only if the signature is valid, so using
>> $pms->action_depends_on_tags doesn't always work.
>> Atm I added a new DKIMCHECKDONE tag on my tree which will be always
>> populated even if no DKIM tag is present.
>> Any other options to do that ? What about all other plugins ? Should we do
>> this where needed or should we write a general, different solution ?
>>
>> Regards
>> Giovanni
>>
>> Index: lib/Mail/SpamAssassin/Plugin/DKIM.pm
>> ===================================================================
>> --- lib/Mail/SpamAssassin/Plugin/DKIM.pm (revision 1876746)
>> +++ lib/Mail/SpamAssassin/Plugin/DKIM.pm (working copy)
>> @@ -971,6 +971,7 @@
>> } else {
>> dbg("dkim: signature verification result: none");
>> }
>> + $pms->set_tag('DKIMCHECKDONE', 1);
>> }
>> }
>>
