On 7/19/2020 7:39 PM, John Hardin wrote: > > The non-can_welcome_block branch should not be renaming the rule. > Doing that breaks existing production installs.
I agree is causing unexpected local rules and local rule scoring issues trying to get pre-3.4.3 releases to work. What do you think of this change along with removing the score from 50_scores.cf? I think it will work back to 3.3.x: if can(Mail::SpamAssassin::Conf::feature_blocklist_welcomelist) #bz7826 renames whitelist to welcomelist header USER_IN_WELCOMELIST_TO eval:check_to_in_welcomelist() describe USER_IN_WELCOMELIST_TO User is listed in 'welcomelist_to' tflags USER_IN_WELCOMELIST_TO userconf nice noautolearn score USER_IN_WELCOMELIST_TO -6.0 else header USER_IN_WELCOMELIST_TO eval:check_to_in_whitelist() describe USER_IN_WELCOMELIST_TO User is listed in 'welcomelist_to' tflags USER_IN_WELCOMELIST_TO userconf nice noautolearn score USER_IN_WELCOMELIST_TO -0.01 meta USER_IN_WHITELIST_TO (USER_IN_WELCOMELIST_TO) describe USER_IN_WHITELIST_TO DEPRECATED: See USER_IN_WELCOMELIST_TO tflags USER_IN_WHITELIST_TO userconf nice noautolearn score USER_IN_WHITELIST_TO -6.0 endif Regards, KAM -- Kevin A. McGrail [email protected] Member, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
