OK, looking at it now! -- Kevin A. McGrail Member, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
On Wed, Dec 30, 2020 at 3:30 AM Giovanni Bechis <giova...@paclan.it> wrote: > On Tue, Dec 29, 2020 at 05:55:02PM -0800, John Hardin wrote: > > On Tue, 29 Dec 2020, bugzilla-dae...@spamassassin.apache.org wrote: > > > > > https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7826 > > > > > > --- Comment #60 from Kevin A. McGrail <kmcgr...@apache.org> --- > > > svn commit -m 'whitelist_auth to welcomelist_auth, > > > unwhitelist_auth to unwelcomelist_auth, > > > def_whitelist_auth to def_welcomelist_auth, > > > check_forged_in_whitelist to check_forged_in_welcomelist, > > > check_from_in_default_whitelist to check_from_in_default_welcomelist, > > > check_uri_host_in_whitelist to check_uri_host_in_welcomelist, > > > check_from_in_blacklist to check_from_in_blocklist, > > > check_to_in_blacklist to check_from_in_blocklist, > > > check_to_in_blacklist to check_to_in_blocklist, > > > and whitelist_bounce_relays to welcomelist_bounce_relays for bug 7826' > > > > > > Sending MANIFEST > > > Sending lib/Mail/SpamAssassin/Conf.pm > > > Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm > > > Sending lib/Mail/SpamAssassin/Plugin/FreeMail.pm > > > Sending lib/Mail/SpamAssassin/Plugin/SPF.pm > > > Sending lib/Mail/SpamAssassin/Plugin/VBounce.pm > > > Sending lib/Mail/SpamAssassin/Plugin/WLBLEval.pm > > > Sending rules/20_vbounce.cf > > > Sending rules/50_scores.cf > > > Sending rules/60_whitelist.cf > > > Sending rules/60_whitelist_auth.cf > > > Adding t/blocklist_autolearn.t > > > Sending t/data/01_test_rules.cf > > > Adding t/freemail_welcome_block.t > > > Adding t/spf_welcome_block.t > > > Transmitting file data ............... > > > Committed revision 1884922. > > > > > > -- > > > > > > I am now getting this when I run a lint test with the WLBLEval plugin > > *not* loaded (which is one of the pre-commit lint tests I have scripted): > > > > Dec 29 17:40:02.717 [25015] warn: rules: error: unknown eval > 'check_from_in_default_whitelist' for USER_IN_DEF_WELCOMELIST > > Dec 29 17:40:02.717 [25015] warn: rules: error: unknown eval > 'check_from_in_whitelist' for USER_IN_WELCOMELIST > > Dec 29 17:40:02.728 [25015] warn: rules: excluding meta test > USER_IN_BLACKLIST_TO, unsolved meta dependencies: USER_IN_BLACKLIST_TO > > Dec 29 17:40:02.728 [25015] warn: rules: excluding meta test > USER_IN_BLACKLIST, unsolved meta dependencies: USER_IN_BLACKLIST > > Dec 29 17:40:02.809 [25015] warn: rules: error: unknown eval > 'check_from_in_blacklist' for USER_IN_BLOCKLIST > > Dec 29 17:40:02.809 [25015] warn: rules: error: unknown eval > 'check_from_in_blacklist_to' for USER_IN_BLOCKLIST_TO > > Dec 29 17:40:02.810 [25015] warn: rules: error: unknown eval > 'check_to_in_whitelist' for USER_IN_WELCOMELIST_TO > > > > > > > > ...I think those modifications may be missing an ifplugin somewhere - or > > perhaps we still have issues with nested if-else-endif in configs? > > > some regression tests on 3.4 tree started to fail as well: > > [giovanni@ 3.4]$ make test > "/usr/bin/perl" build/mkrules --exit_on_no_src --src rulesrc --out rules > --manifest MANIFEST --manifestskip MANIFEST.SKIP > "/usr/bin/perl" build/preprocessor -Mvars -DVERSION="3.004005" > -DPREFIX="/usr/local" -DDEF_RULES_DIR="/usr/local/share/spamassassin" > -DLOCAL_RULES_DIR="/etc/mail/spamassassin" > -DLOCAL_STATE_DIR="/var/lib/spamassassin" > -DINSTALLSITELIB="/usr/local/share/perl5/5.32" -DCONTACT_ADDRESS="the > administrator of that system" -DRE2C_BIN="re2c" -Msharpbang -Mconditional > -DPERL_BIN=""/usr/bin/perl"" -DPERL_WARN="" -DPERL_TAINT="" -m755 > -isa-update.raw -osa-update > cp sa-update blib/script/sa-update > "/usr/bin/perl" -MExtUtils::MY -e 'MY->fixin(shift)' -- > blib/script/sa-update > PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" > "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, > 'blib/lib', 'blib/arch')" t/*.t > t/all_modules.t ................... 1/5 Found anti-pattern: warn > = warn: at t/all_modules.t line 92. > > # Failed test at t/SATest.pm line 821. > Output can be examined in: log/d.all_modules/0 > # Looks like you failed 1 test of 5. > t/all_modules.t ................... Dubious, test returned 1 (wstat 256, > 0x100) > Failed 1/5 subtests > t/autolearn.t ..................... Dec 30 09:25:57.450 [5837] warn: > rules: error: unknown eval 'check_from_in_blacklist_to' for > USER_IN_BLOCKLIST_TO > Dec 30 09:25:57.575 [5837] warn: rules: error: unknown eval > 'check_welcomelist_bounce_relays' for __MY_SERVERS_FOUND > t/autolearn.t ..................... ok > t/autolearn_force.t ............... Dec 30 09:25:59.398 [5845] warn: > rules: error: unknown eval 'check_from_in_blacklist_to' for > USER_IN_BLOCKLIST_TO > Dec 30 09:25:59.525 [5845] warn: rules: error: unknown eval > 'check_welcomelist_bounce_relays' for __MY_SERVERS_FOUND > t/autolearn_force.t ............... ok > t/autolearn_force_fail.t .......... ^Cmake: *** [Makefile:1396: > test_dynamic] Interrupt >
