On 30 Apr 2021, at 12:05, Benny Pedersen wrote:

On 2021-04-30 17:38, Bill Cole wrote:
On 30 Apr 2021, at 10:29, John Hardin wrote:
On Fri, 30 Apr 2021, Henrik K wrote:
Please do not commit anything without make/lint check. :-(

+1

-header  __HAS_LIST_ID           exists:List-Id
+meta    __HAS_LIST_ID           __ML2

Also, this should be the other way around - be consistent with __HAS_{headername} subrules being simply "the header exists", and if you want to alias it then make the *other* rule with the nonstandard name the meta.

I don't really have a preference one way or the other, only for not
having 2 identical but independent rules.

maillist.pm exists ?

No, it does not. At least not anywhere I can find...

imho detection on maillists should be made in this core module

Do you mean Mail::SpamAssassin::MailingList.pm?

That is an undocumented module which was last given specific attention in 2004, is not covered by the test suite, and is not used by any rule or any other SA module. I confess to being unaware of its existence when putting together the MAILING_LIST_MULTI rule but even now that I know, I do not see what benefit it would provide to use that (or any) module where a meta rule can suffice and be dynamically maintained. It seems more reasonable to just drop that module, as it seems likely that it has not been used by anyone for the past 10+ years, across many SA versions.

--
Bill Cole
[email protected] or [email protected]
(AKA @grumpybozo and many *@billmail.scconsult.com addresses)
Not Currently Available For Hire

Reply via email to