https://bz.apache.org/SpamAssassin/show_bug.cgi?id=5859

Sidney Markowitz <sid...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sid...@sidney.com

--- Comment #14 from Sidney Markowitz <sid...@sidney.com> ---
(In reply to RW from comment #13)
> IMO the following two lines are in the wrong order
> 
>    return 0 if (length $subject < 10);  # don't match short subjects
>    $subject =~ s/[^a-zA-Z]//g;          # only look at letters

That makes sense, but as an alternate fix, consider that the return line does
check the length after stripping like this:

  return length($subject) && ($subject eq uc($subject));

We could make it length($subject) < n for some number that makes sense. I don't
know what n should be, though, without experimenting with ruleqa with different
amounts. It does have to be something less than 10, or else the current code
makes no sense at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to