https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7976

Michael Storz <sa-...@lrz.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sa-...@lrz.de

--- Comment #1 from Michael Storz <sa-...@lrz.de> ---
more minor problems:

grep -P 'warn[\s(]"|\{rule_errors' lib/Mail/SpamAssassin/Plugin/Check.pm 
        warn("check: dns_block_rule $rule hit, creating $blockfile ".
      warn("rules: unknown eval '$function' for $rulename, ignoring RBL
eval\n");
      warn "rules: failed to run $rulename RBL test, skipping:\n".
      $pms->{rule_errors}++;
      warn "rules: failed to compile $ruletype tests, skipping:\n".
      $pms->{rule_errors}++;
    warn "rules: failed to compile $chunk_methodname, skipping:\n".
    $pms->{rule_errors}++;
      warn "rules: error: no eval function defined for $rulename";
      warn("rules: error: unknown eval '$function' for $rulename\n");
    warn "rules: failed to compile eval tests, skipping some: $eval_stat\n";
    $self->{rule_errors}++;

- missing \n in ...no eval function...
- either use warn("...") or warn "..."
- some of the warn statements increment the error counter for lint_warn others
don't. This results in inconsistent error message. All warn should increment
the counter.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to