https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7786
Henrik Krohns <apa...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|4.0.0 |SVN Trunk (Latest Devel
| |Version)
CC| |apa...@hege.li
Priority|P2 |P3
OS|OpenBSD |All
Hardware|PC |All
Severity|normal |enhancement
--- Comment #1 from Henrik Krohns <apa...@hege.li> ---
Not sure what the purpose of keeping this bug open is.. of course you are free
to commit it for SA project to take over maintaining. But please not "Clamav",
as again proper designation for it is "ClamAV".. details matter.
But here's some observations if that was the point of this bug:
- clamd_sock seems to assume that clamd is always running on localhost and not
some other server
- it's useless to have separate hardcoded "check_clamav_sanesecurity" function,
everything should go through check_clamav, otherwise you need to update plugin
and if can(foo) constantly for every signature. So check_clamav() should just
accept a custom regex
- add result caching if called multiple times (with different regex as above
for different scoring etc)
- it's loading two modules needlessly, try loading other only if other was not
available
- why is it using $self->{main}->{registryboundaries}->{conf}
- of course custom async call would be preferable, instead of waiting for clamd
response. The protocol is so simple it's probably pointless to even use
external modules for this.
So I'd rather see it committed only after much polishing.
--
You are receiving this mail because:
You are the assignee for the bug.
