On 5/1/2022 6:23 PM, Bill Cole wrote:
It helps to understand that detect_utf16() is called in exactly one place: in another part of Node.pm. It is called there in scalar context. In scalar context, 'return' without an argument returns undef. There's no logical reason for it to ever be called in list context, since what it is returning is (a pointer to) an Encode object.
And a pointer isn't going to cause any heavy computation.  Perhaps just a cleaner comment then and we are good or just ignore it because we have bigger fish to fry!

--
Kevin A. McGrail
kmcgr...@apache.org

Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

Reply via email to