https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7987
Bug ID: 7987 Summary: DNSEval.pm,HashBL.pm,URILocalBL.pm: unnecessary use of rule_pending and rule_ready Product: Spamassassin Version: 4.0.0 Hardware: All OS: All Status: NEW Severity: minor Priority: P2 Component: Plugins Assignee: dev@spamassassin.apache.org Reporter: sa-...@lrz.de Target Milestone: Undefined Rules that perform asynchronous DNS lookups via bgsend_and_start_lookup do not need to be manually flagged via rule_pending and rule_read, as everything is done automatically via additions and deletions to pending_rules. The end game, the call to finish_meta_tests, is prepared by the call to harvest_dnsbl_queries, which in turn calls abort_remaining_lookups. Therefore the calls of rule_pending and rule_ready can and should be deleted. If rule_pending/rule_ready would be needed, then all registered eval functions of DNSEval.pm would need these calls, which is at the moment not the case. -- You are receiving this mail because: You are the assignee for the bug.