A quick hack to run it without taint, created t/perlcritic.t which contains:
#!/usr/bin/perl
$ENV{'PATH'} = '/bin:/usr/bin';
-d "xt" && "$^X xt/60_perlcritic.t" =~ /(.*)/ ||
"$^X ../xt/60_perlcritic.t" =~ /(.*)/;
exec($1);
Let me know if you think it can be committed. I'll atleast leave it on my
local copy so it gets run..
On Tue, May 10, 2022 at 06:50:17AM +0300, Henrik K wrote:
>
> Any objections on making perlcritic run by default with make test?
>
> It's obviously useful and seems a waste to only run on release checks.
>
> On Tue, May 10, 2022 at 06:41:40AM +0300, Henrik K wrote:
> >
> > Duh.. embarassed for the bug. Good job perlcritic. :-D
> >
> > On Tue, May 10, 2022 at 03:22:40AM -0000, sid...@apache.org wrote:
> > > Author: sidney
> > > Date: Tue May 10 03:22:40 2022
> > > New Revision: 1900770
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1900770&view=rev
> > > Log:
> > > make a map non-destructive fixes perlcritic error and makes it not
> > > destroy the list
> > >
> > > Modified:
> > > spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm
> > >
> > > Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm
> > > URL:
> > > http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm?rev=1900770&r1=1900769&r2=1900770&view=diff
> > > ==============================================================================
> > > --- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm
> > > (original)
> > > +++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm Tue
> > > May 10 03:22:40 2022
> > > @@ -443,7 +443,7 @@ sub _check_fromnamespoof {
> > > foreach my $list (@lists) {
> > > $list_refs->{$list} = $conf->{$list};
> > > }
> > > - dbg("using addrlists for owner aliases: ".join(', ', map {
> > > s/^FNS_//; $_ } @lists));
> > > + dbg("using addrlists for owner aliases: ".join(', ', map {
> > > s/^FNS_//r; $_ } @lists));
> > > }
> > > my $fromname_owner = $self->_find_address_owner($fromname_addr,
> > > $fromname_domain, $list_refs);
> > > my $from_owner = $self->_find_address_owner($from_addr, $from_domain,
> > > $list_refs);
> > >
