https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8029
Bug ID: 8029
Summary: Clean up some spamd tests that use the pid file
Product: Spamassassin
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P2
Component: Regression Tests
Assignee: dev@spamassassin.apache.org
Reporter: sid...@sidney.com
Target Milestone: Undefined
The tests spamd_hup.t, spamd_kill_restart.t and spamd_kill_restart_rr.t all
make use of the -r option to specify a file for spamd to write the pid, then to
some tests with that file. However, start_spamd in t/SATest.pm already always
uses the -r option. The tests only happen to work because they use the same
file name as in SATest.pm and spamd doesn't seem to do anything wrong when
given the option twice.
This issue is to clean that up by making the $spamd_pidfile variable used in
SATest.pm visible to the tests and removing the redundant option in the tests.
I note that the only test failures we are currently seeing on CPAN test
machines are on one tester's machines that consistently fail t/spamd_hup.t
because they can't find the spamd pid file. Even though I can't figure out how
this issue could be responsible for that, it is worth cleaning it up.
--
You are receiving this mail because:
You are the assignee for the bug.
