https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8039
Bug ID: 8039
Summary: [REVIEW] Remove unused lines of code left in
Makefile.PL by accident
Product: Spamassassin
Version: 4.0.0
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P2
Component: Building & Packaging
Assignee: dev@spamassassin.apache.org
Reporter: sid...@sidney.com
Target Milestone: Undefined
Created attachment 5808
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5808&action=edit
Patch to remove declaration and initialization of never-used %CURRENT_PM
If we were not in RTC mode in a release candidate I would just commit this
maybe even without a bug report, but I am following the release process so
someone can vote to stop me if necessary.
Makefile.PL sets a variable %CURRENT_PM to what used to be minimum versions of
Net::DNS and Razor2::Client. The variable is then never used anywhere. Those
versions are not even the correct minimum ones anymore. This has been bothering
me since I noticed it the day after going to RTC mode.
What I did to track down that the variable really, really, really, really isn't
referenced anywhere:
Searched through SpamAssassin source tree, not in svn repository, came up empty
find . -type f -exec grep CURRENT_PM {} \; -print
Searched the source of ExtUtils::MakeMaker to verify that it does not make use
of anything named CURRENT_PM
Searched the git history of Extutils::Makemaker to verify that it never used
anything named CURRENT_PM
Searched the git mirror of the SpamAssassin svn for all commits that contained
the string CURRENT_PM in the diff (svn doesn't have that handy feature).
Excluding commits from tagging, there were only two, both from bug 3822.
CURRENT_PM was added to Makefile.PL in the first commit to bug 3822 which was
revision 5527 in which CURRENT_PM was set and used to check versions if the
modules were installed. Later in that same bug was revision 125018 in which the
checking of modules was moved out of Makefile.PL but apparently by accident the
initialization of that variable was not deleted.
I'm attaching a proposed patch that removes the useless lines from Makefile.PL
and calling for votes to commit. +1 from me, of course.
Please vote
--
You are receiving this mail because:
You are the assignee for the bug.
