https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050

Sidney Markowitz <sid...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5830|0                           |1
        is obsolete|                            |

--- Comment #32 from Sidney Markowitz <sid...@sidney.com> ---
Created attachment 5831
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5831&action=edit
Patch v4

(In reply to Henrik Krohns from comment #31)
> Likely it's loaded by some deeper module that SA depends on..

Ok, that totally makes sense, and the conditional require can go in a BEGIN
block. I would prefer having code like that put in Util.pm instead of
SpamAssassin.pm so here is v4 of the patch with these changes:

The call to the Win32 functions has been moved to a sub in Utils.pm with the
require Win32 added to a Windows-only BEGIN block that was already there.

The call in SpamAssassin.pm is now to the sub in Utils instead of the Win32
functions.

How does it look now?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to