https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8066
Bug ID: 8066
Summary: [review] Some files in svn have svn:eol-style property
incorrectly set
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: Windows
Status: NEW
Severity: normal
Priority: P2
Component: Building & Packaging
Assignee: dev@spamassassin.apache.org
Reporter: sid...@sidney.com
Target Milestone: Undefined
The following is a list of all files in svn trunk that have the svn:eol-style
property set. All of them have the property set to 'native'. These files will
have Windows style newlines when checked out on a Windows platform. All other
files will have whatever newline style they were committed with, typically Unix
style newlines if they are text files.
build/announcements/3.4.5.txt
build/announcements/3.4.6.txt
build/announcements/4.0.0.txt
spamc/spamc.pod
t/dkim.t
t/dnsbl_subtests.t
t/header_utf8.t
t/html_utf8.t
t/idn_dots.t
t/originating_ip_hdr.t
t/recreate.t
t/rule_multiple.t
t/timeout.t
lib/Mail/SpamAssassin/Plugin/AskDNS.pm
Because perl on Windows is able to handle either newline style in perl code
files, none of these files cause any problems with SpamAssassin checked out
from svn on Windows. However, this does produce an inconsistency in those files
and in the distribution tarballs and zip files which are usually produced on a
Linux platform where all the text files will have Unix style newlines.
Working on bug 8056, I encountered a failure in t/get_all_headers.t run as a
Github action on the Windows runner. I started to type the details, but it got
too verbose for here. Suffice it to say that the workaround in the Github
action is simpler if we don't have any files with svn:eol-style set in the
repository, and it looks like that is the more correct thing anyway.
I propose to remove the property from those files using the command
svn propdel svn:eol-style [file list ...]
The only file that needs a vote to commit with this change under RTC is
AskDNS.pm so I'm calling for a vote for that one and I'm committing the change
for all the rest. I want to get this in for 4.0.0 because I hope to have all
tests passing on Github action runners as part of the release QA process. +1
from me, of course.
--
You are receiving this mail because:
You are the assignee for the bug.
