https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8068
Bug ID: 8068
Summary: t/spamd_ssl_accept_fail.t failure on slow systems
Product: Spamassassin
Version: 4.0.0
Hardware: PC
OS: Linux
Status: NEW
Severity: minor
Priority: P2
Component: Regression Tests
Assignee: dev@spamassassin.apache.org
Reporter: sid...@sidney.com
Target Milestone: Undefined
t/spamd_ssl_accept_failt.t was written to test the fix for bug 4107 which was
spamd crashing when it was launched with the option to accept only ssl
connections and spamc called it using non-ssl protocol.
The test consists of launching spamd with ssl option, calling it once with
spamc without ssl, then again with spamc using ssl, then stopping spamd,
confirming that the combined return from the two calls to spamc contains the
expected spam report from the second call.
In setting up testing on GitHub Actions, the test fails with the second spamc
call not appearing to contact spmd, same as the non-ssl call.
If I add a sleep(1) between the first and second call of spamc, the test works.
I suspect that the fix for bug 4107 does not prevent the child process from
crashing when it receives the non-ssl call from spamc. That is good enough as
far as the fix goes, because the child gets re-spawned.
If I'm right about the cause of the test failure, it is only a problem if spamd
is running using ssl on a slower than useful for production system and spamc
calls it without ssl from a machine that has access to the spamd port and then
a proper ssl call from spamc happens less than a second later, and then the
only result is that the second spamc call fails. If that is the only failure
scenario I think it would be fine to just add a sleep(1) to the test so that it
can pass on slow systems like the GitHub action runner.
If anyone wants to look at the code and and make a more robust fix for bug 4107
that keeps the child from crashing, feel free.
Since my proposed change is only in the test, I think I can commit it for 4.0.0
without a vote.
--
You are receiving this mail because:
You are the assignee for the bug.
