On Mon, Dec 26, 2022 at 01:02:30PM +0200, Henrik K wrote: > On Mon, Dec 26, 2022 at 11:54:12AM +0100, Giovanni Bechis wrote: > > > > dnsbl_subtests.t tests runs even with run_net_tests=n (fixed few minutes > > ago in trunk) > > The fix is not needed. > > dnsbl_subtests.t starts a _local_ nameserver and never sends queries to > public internet. > > The intention of run_net_tests=n is to prevent test scripts from failing if > you don't have a internet connection. This test does not require a working > connection.
Additional thoughts for devs... Not sure why all tests don't use the same method. Seems pointless to have an external dependency to a public dnsbltest.spamassassin.org zone, when you could just host it locally like dnsbl_subtests.t does. It would provide consistent results and not require anyone to manually activate run_net_tests for those tests. Not volunteering to implement it though. ;-)
