https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8201
Henrik Krohns <apa...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
CC| |apa...@hege.li
Resolution|FIXED |---
--- Comment #2 from Henrik Krohns <apa...@hege.li> ---
(In reply to Sidney Markowitz from comment #0)
> Created attachment 5920 [details]
> proposed patch
>
> There are four tests that are written to iterate $iterations times, with
> explanation in the comment that it is to allow for random natural failures.
> I'm seeing such occasional failures showing up on CPAN testing machines
> running Windows with versions of Strawberry perl 5.24 and older
>
> basic_meta2.t dnsbl.t hashbl.t uribl.t
>
> The problem with the current implementation is that a failure in any of the
> iterations is considered a test failure.
I think you may have misunderstood.
My code comment is: "run many times to catch some random natured failures"
And yours is "allow for random natural failures". This is completely different
thing, sorry if my comment was vague.
It's crucial that each and every test succeeds without failure, that's the
point of the iterations. Internal random running order of rules can affect the
outcome as was seen in the past. Why it happens on Windows should be
investigated.
--
You are receiving this mail because:
You are the assignee for the bug.
