On 12/17/2024 9:57 PM, Kent Oyer wrote:
What are your thoughts about adding dependencies to SpamAssassin?
Currently SA doesn't support RFC 2231 (Character Set and Parameter
Continuations) in the Content-Disposition header and only partial
support in the Content-Type header. So it's possible to obfuscate a
file name using this syntax:
Content-Disposition: attachment; filename*0=invoice.h;
filename*1=tml
In order to not reinvent the wheel, I'd like to use
`parse_content_type` and `parse_content_disposition`
from Email::MIME::ContentType but that adds another dependency. Is
this ok or should it be avoided? Do I just add the dependency to
Makefile.PL and Mail/SpamAssassin/Util/DependencyInfo.pm? Are there
any other considerations?
Thanks
Kent
Generally I think external dependencies have been frowned upon. It's
usually easier to fix internal than external code. :-)
Email::MIME::ContentType seems to require Text::Unicode which also has
to be considered.
Both modules would need to be available on few previous versions of all
major distributions to be considered a hard requirement. They could be
made optional, so only used if installed, otherwise revert to old SA code.
Just my few unofficial cents, don't remember if there is mandate written
somewhere.
Cheers,
Henrik
