https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8385

            Bug ID: 8385
           Summary: ReplaceTags plugin totally ignores tag named "0" (and
                    possibly others) due to Perl "falsy" logic
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Plugins
          Assignee: [email protected]
          Reporter: [email protected]
  Target Milestone: Undefined

Created attachment 6061
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=6061&action=edit
Let ReplaceTags use "falsy" tag names

The recently defined replace tag <0> was found to not be working. Analysis
found:

   if ($tag_name) {                                                             

When $tag_name is the string "0", Perl treats it as falsy. The replacement is
silently skipped. Every other digit tag (<1> through <9>) has a truthy name -
<0> is the only one broken by this.

Renaming the tag to <ZERO> because this is a longstanding bug and the fix is
unlikely to be backported.

A proposed code fix is attached.

Should also probably do a feature property so we can do something like this in
rules:

#if can(Mail::SpamAssassin::Conf::feature_bug6558_free)


The use case is so narrow that this may not be worth fixing...

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to