sidney commented on PR #37: URL: https://github.com/apache/spamassassin/pull/37#issuecomment-5329739855
I was just starting on that too. I've been going through to verify that there's no obscure bug to be introduced. There is a difference between return undef; and return; if it is called in list mode. But I think I've proven that it can't be called that way in any of these cases. There are a couple more files where the Perlcritic test was silenced which should be fixed the same way instead, I'll get those too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
