https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8418
Bug ID: 8418
Summary: rules/25_url_shortener.cf is wrong after the plugin
merge
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Plugins
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: Undefined
Now that DecodeShortURLs has been merged into Redirectors
rules/25_url_shortener.cf no longer loads properly. It has lines
if can(Mail::SpamAssassin::Plugin::DecodeShortURLs::has_short_url_redir)
and
if !can(Mail::SpamAssassin::Plugin::DecodeShortURLs::has_short_url_redir)
I was going to say they have to be changed to use Redirectors:: and that's what
I tested with successfully against trunk, but I realized that could break
someone who runs sa-update who is not running latest trunk.
Is that correct, or does sa-update get different files for 4.0.x and trunk?
Should those limes be changed for backwards compatibility to
if can(Mail::SpamAssassin::Plugin::Redirectors::has_short_url_redir) ||
can(Mail::SpamAssassin::Plugin::DecodeShortURLs::has_short_url_redir)
and
if !(can(Mail::SpamAssassin::Plugin::Redirectors::has_short_url_redir) ||
can(Mail::SpamAssassin::Plugin::DecodeShortURLs::has_short_url_redir))
--
You are receiving this mail because:
You are the assignee for the bug.