https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8471
Sidney Markowitz <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Sidney Markowitz <[email protected]> --- The three return undef; lines cause t/perlcritic.t failures. They can be simple return; statements because they are always called in scalar context. I agree with what Giovanni said about the rules/25_url_shortener.cf change. It looks like a leftover from your testing that you didn't intend to make part of the patch. The (probably) inadvertent tinyl.IO change would have disabled that entry, because entries are stored as written but compared with the lower-cased host. That revealed two other problems that can be fixed in this patch. 4.0.2 did lower-case the entries, but that was lost when per-path matching was added. _add_redirector_entry should lower-case the host part, but not the path. _clear_redirector_entry has the opposite problem: it lower-cases the whole token, path included. The shipped entry .awstrack.me/L0/ shows why the path has to keep its case, and it reveals the bug now in clear_url_redirector which would not remove it. I'll +1 this with those three changes: return undef, remove the .cf file from the patch, the two lc changes -- You are receiving this mail because: You are the assignee for the bug.
