Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/42#discussion_r10186874
--- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.util
+
+import java.io._
+import java.text.SimpleDateFormat
+import java.util.Date
+
+import org.apache.spark.Logging
+
+/**
+ * A generic class for logging information to file
+ * @param logDir Path to the directory in which files are logged
+ * @param name An identifier of each FileLogger instance
+ */
+class FileLogger(
+ logDir: String = Option(System.getenv("SPARK_LOG_DIR"))
+ .getOrElse("/tmp/spark-%s".format(System.getProperty("user.name",
"user"))),
+ name: String = String.valueOf(System.currentTimeMillis()))
+ extends Logging {
+
+ private val logPath = logDir.stripSuffix("/") + "/" + name
+ private val DATE_FORMAT = new SimpleDateFormat("yyyy/MM/dd HH:mm:ss")
+ private var fileIndex = 0
+
+ private var writer: Option[PrintWriter] = {
+ createLogDir()
+ Some(createWriter())
+ }
+
+ /** Create a logging directory with the given path */
+ private def createLogDir() = {
+ val dir = new File(logPath)
+ if (dir.exists) {
+ logWarning("Logging directory already exists: " + logDir)
+ }
+ if (!dir.exists && !dir.mkdirs()) {
+ // Logger should throw a exception rather than continue to construct
this object
+ throw new IOException("Error in creating log directory:" + logDir)
+ }
+ }
+
+ /** Create a new writer to the file identified with the given path */
+ private def createWriter() = {
+ // Overwrite any existing file
+ val fileWriter = new FileWriter(logPath + "/" + fileIndex)
--- End diff --
For this we should use the Hadoop FileSystem API rather than a java file
writer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
