Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/94#discussion_r10364545
  
    --- Diff: core/src/test/scala/org/apache/spark/PipedRDDSuite.scala ---
    @@ -89,4 +97,37 @@ class PipedRDDSuite extends FunSuite with 
SharedSparkContext {
         }
       }
     
    +  test("test pipe exports map_input_file") {
    +    testExportInputFile("map_input_file")
    +  }
    +
    +  test("test pipe exports mapreduce_map_input_file") {
    +    testExportInputFile("mapreduce_map_input_file")
    +  }
    +
    +  def testExportInputFile(varName:String) {
    +    val nums = new HadoopRDD(sc, new JobConf(), classOf[TextInputFormat], 
classOf[LongWritable],
    --- End diff --
    
    Just wondering - any reason to create this whole fake `HadoopRDD` rather 
than just make a temporary file and call `sc.textFile()`? Seems okay either 
way, I just couldn't tell if there was something else gained by doing that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to