Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10368525
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -30,16 +32,23 @@ import org.apache.spark.scheduler._
      * class, since the UI thread and the DAGScheduler event loop may otherwise
      * be reading/updating the internal data structures concurrently.
      */
    -private[spark] class JobProgressListener(val sc: SparkContext) extends 
SparkListener {
    +private[ui] class JobProgressListener(sc: SparkContext, live: Boolean)
    +  extends StorageStatusSparkListener {
    --- End diff --
    
    Makes sense. The fact that storage status list isn't updated is a bug; I 
forgot to add  super.onTaskEnd to JobProgressListener. However, this will no 
longer be relevant in the new proposal, which involves JobProgressListener 
extending the usual SparkListener as you suggest, and listening for the trimmed 
ExecutorStateChange events. (More details in discussion above)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to