Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/42#discussion_r10458380
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -69,19 +100,55 @@ private[spark] class SparkUI(sc: SparkContext) extends
Logging {
// DAGScheduler() requires that the port of this server is known
--- End diff --
Neither are the two lines that follow. I don't see a necessary ordering
between start() and bind(), now that DAGScheduler no longer requires the UI
port. The only ordering requirement is that SparkListenerBus must be
instantiated before start(), and this is quite clear in SparkContext.
(That said, I prefer to keep bind() and start() separate as they already
are, for code clarity reasons)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
