Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/116#issuecomment-37255431
Here are some of your questions from the previous PR, let me answer inline:
1. *Based [SPARK-929] would it make sense to also include
--spark-daemon-memory as an optional argument.?*
- spark-daemon-memory should only be configured very rarely, so I think
we can avoid this.
2. *Should I rebase my changes taking into account [SPARK-929], I assume I
should.*
- N/A - I think you already have (correctly so)
3. *Might make sense to have a ./bin/_funcitons.sh to share bash functions
across scripts, mainly used by spark-shell and spark-submit (based on
[SPARK-1126]) e.g. of functions could be INFO, WARN, ERROR messages.*
- I think we can keep these functions in here until some other script
wants to use them. Usage of colors in bash scripts should be kept somewhat
limited, however, since it doesn't interact well when piped to things other
than terminals. I think it's probably OK for a "shell" type program since we're
not likely to pipe that anywhere, as long as dumb (colorless) terminals don't
display weird characters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
