Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-37262156
@mengxr Thanks for such a detailed review. The code is already in a much
better shape after incorporating your suggested changes. I have fixed the
straightforward code style issues and will commit shortly. I still need to make
more code style changes and document the findBestSplit method in detail.
I need some more time to think about your implementation suggestions. I
also need to seriously consider @srowen's suggestion about adding multi-class
classification in this version of the PR. I will get back to you on this
tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
