It might still make sense to make this change if MIMA checks are always relatively quick, for the same reason we do style checks first.
On Thu, Sep 25, 2014 at 12:25 AM, Nan Zhu <zhunanmcg...@gmail.com> wrote: > yeah, I tried that, but there is always an issue when I ran dev/mima, > > it always gives me some binary compatibility error on Java API part…. > > so I have to wait for Jenkins’ result when fixing MIMA issues > > -- > Nan Zhu > > > On Thursday, September 25, 2014 at 12:04 AM, Patrick Wendell wrote: > > > Have you considered running the mima checks locally? We prefer people > > not use Jenkins for very frequent checks since it takes resources away > > from other people trying to run tests. > > > > On Wed, Sep 24, 2014 at 6:44 PM, Nan Zhu <zhunanmcg...@gmail.com > (mailto:zhunanmcg...@gmail.com)> wrote: > > > Hi, all > > > > > > It seems that, currently, Jenkins makes MIMA checking after all test > cases have finished, IIRC, during the first months we introduced MIMA, we > do the MIMA checking before running test cases > > > > > > What's the motivation to adjust this behaviour? > > > > > > In my opinion, if you have some binary compatibility issues, you just > need to do some minor changes, but in the current environment, you can only > get if your change works after all test cases finished (1 hour later...) > > > > > > Best, > > > > > > -- > > > Nan Zhu > > > > > > > > > > > >
