Hi all, Lately, I made a list of rules currently not applied on Spark from http://www.scalastyle.org/rules-dev.html and then I tried to test them.
I found two rules that I think might be helpful but I am not too sure. Could I ask both can be added? *RedundantIfChecker *(See http://www.scalastyle.org/rules-dev.html#org_scalastyle_scalariform_RedundantIfChecker ) It seems there are two usage of this. This simply checks if (cond) true else false or if (cond) false else true,which can be just cond or !cond *ProcedureDeclarationChecker *(See http://www.scalastyle.org/rules-dev.html#org_scalastyle_scalariform_ProcedureDeclarationChecker ) It seems this simply checks if functions has the return type `= :Unit` explicitly. This one seems right because it is written in https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-ReturnTypes However, it seems the number of occurrence is super a lot. (It seems roughly more than 800 times). It seems this will cause a lot of conflicts. Here is a list of rules not mentioned in scalastyle-config.xml just in case someone wants to know. *IndentationChecker* <check enabled="true" class="org.scalastyle.file.IndentationChecker" level="warning"> <parameters> <parameter name="tabSize">2</parameter> <parameter name="methodParamIndentSize">2</parameter> </parameters> </check> *BlockImportChecker* <check enabled="true" class="org.scalastyle.scalariform.BlockImportChecker" level="warning"/> *DeprecatedJavaChecker* <check enabled="true" class="org.scalastyle.scalariform.DeprecatedJavaChecker" level="warning"/> *EmptyClassChecker* <check enabled="true" class="org.scalastyle.scalariform.EmptyClassChecker" level="warning"/> *ForBraceChecker* <check enabled="true" class="org.scalastyle.scalariform.ForBraceChecker" level="warning"/> *LowercasePatternMatchChecker* <check enabled="true" class="org.scalastyle.scalariform.LowercasePatternMatchChecker" level="warning"/> *MultipleStringLiteralsChecker* <check enabled="true" class="org.scalastyle.scalariform.MultipleStringLiteralsChecker" level="warning"> <parameters> <parameter name="allowed">1</parameter> <parameter name="ignoreRegex">^\"\"$</parameter> </parameters> </check> *PatternMatchAlignChecker* <check enabled="true" class="org.scalastyle.scalariform.PatternMatchAlignChecker" level="warning"/> *ProcedureDeclarationChecker* <check enabled="true" class="org.scalastyle.scalariform.ProcedureDeclarationChecker" level="warning"/> *RedundantIfChecker* <check enabled="true" class="org.scalastyle.scalariform.RedundantIfChecker" level="warning"/> *ScalaDocChecker* <check enabled="true" class="org.scalastyle.scalariform.ScalaDocChecker" level="warning"> <parameters> <parameter name="ignoreRegex">(.*Spec$)|(.*SpecIT$)</parameter> </parameters> </check> *TodoCommentChecker* <checker enabled="true" class="org.scalastyle.scalariform.TodoCommentChecker" level="warning"> <parameters> <parameter default="TODO|FIXME" type="string" name="words"/> </parameters> </checker> *VarFieldChecker* <check enabled="true" class="org.scalastyle.scalariform.VarFieldChecker" level="warning"/> *VarLocalChecker* <check enabled="true" class="org.scalastyle.scalariform.VarLocalChecker" level="warning"/> *WhileChecker* <check enabled="true" class="org.scalastyle.scalariform.WhileChecker" level="warning"/> *XmlLiteralChecker* <check enabled="true" class="org.scalastyle.scalariform.XmlLiteralChecker" level="warning"/> Thank you very much!!
