Latest 4.0.x is Netty 4.0.42 and master is already on that version.

My comments earlier were about the version of Netty that Spark 2.0.2 uses,
which is why I thought you were talking about branch-2.0.

Anyway, I don’t think we need to do anything here. If someone is having
serious Netty problems caused by low entropy, they can install Haveged
<https://wiki.archlinux.org/index.php/Haveged> (which is what I did!) or
just wait and upgrade to Spark 2.1.0.

Nick

On Mon, Dec 5, 2016 at 8:57 PM Shixiong(Ryan) Zhu <shixi...@databricks.com>
wrote:

No. I meant only updating master. It's not worth to update a maintenance
branch unless there are critical issues.

On Mon, Dec 5, 2016 at 5:39 PM, Nicholas Chammas <nicholas.cham...@gmail.com
> wrote:

You mean just for branch-2.0, right?
​

On Mon, Dec 5, 2016 at 8:35 PM Shixiong(Ryan) Zhu <shixi...@databricks.com>
wrote:

Hey Nick,

It should be safe to upgrade Netty to the latest 4.0.x version. Could you
submit a PR, please?

On Mon, Dec 5, 2016 at 11:47 AM, Nicholas Chammas <
nicholas.cham...@gmail.com> wrote:

That file is in Netty 4.0.29, but I believe the PR I referenced is not.
It's only in Netty 4.0.37 and up.


On Mon, Dec 5, 2016 at 1:57 PM Ted Yu <yuzhih...@gmail.com> wrote:

This should be in netty-all :

$ jar tvf
/home/x/.m2/repository/io/netty/netty-all/4.0.29.Final/netty-all-4.0.29.Final.jar
| grep ThreadLocalRandom
   967 Tue Jun 23 11:10:30 UTC 2015
io/netty/util/internal/ThreadLocalRandom$1.class
  1079 Tue Jun 23 11:10:30 UTC 2015
io/netty/util/internal/ThreadLocalRandom$2.class
  5973 Tue Jun 23 11:10:30 UTC 2015
io/netty/util/internal/ThreadLocalRandom.class

On Mon, Dec 5, 2016 at 8:53 AM, Nicholas Chammas <nicholas.cham...@gmail.com
> wrote:

I’m looking at the list of dependencies here:

https://github.com/apache/spark/search?l=Groff&q=netty&type=Code&utf8=%E2%9C%93

What’s the difference between netty and netty-all?

The reason I ask is because I’m looking at a Netty PR
<https://github.com/netty/netty/pull/5345> and trying to figure out if
Spark 2.0.2 is using a version of Netty that includes that PR or not.

Nick
​




​

Reply via email to