Hi, Just noticed that both MapOutputTrackerMaster [1] and MapOutputTrackerWorker [2] use Java's ConcurrentHashMap for mapStatuses [3] which makes this abstract mapStatuses attribute less abstract. I think it was the outcome of some refactoring that led to a small duplication (and makes the distinction between MapOutputTrackerMaster and MapOutputTrackerWorker...spurious?).
Why do you think about removing the duplication? (There's another change with post(message: GetMapOutputMessage) to use consistently instead of mapOutputRequests.offer(message) that would make the change initially small slightly bigger and perhaps more acceptable). [1] https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/MapOutputTracker.scala#L292 [2] https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/MapOutputTracker.scala#L596 [3] https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/MapOutputTracker.scala#L84 Pozdrawiam, Jacek Laskowski ---- https://medium.com/@jaceklaskowski/ Mastering Apache Spark 2.0 https://bit.ly/mastering-apache-spark Follow me at https://twitter.com/jaceklaskowski --------------------------------------------------------------------- To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
