Is it worth to come up with a proposal for this and float to dev?

________________________________
From: Reynold Xin <[email protected]>
Sent: Wednesday, January 11, 2017 9:47 AM
To: Maciej Szymkiewicz; Saikat Kanjilal; [email protected]
Subject: Re: [PYSPARK] Python tests organization

It would be good to break them down a bit more, provided that we don't increase 
for example total runtime due to extra setup.


On Wed, Jan 11, 2017 at 9:45 AM Saikat Kanjilal 
<[email protected]<mailto:[email protected]>> wrote:















Hello Maciej,



If there's a jira available for this I'd like to help get this moving, let me 
know next steps.



Thanks in advance.












________________________________


From: Maciej Szymkiewicz <[email protected]<mailto:[email protected]>>


Sent: Wednesday, January 11, 2017 4:18 AM


To: [email protected]<mailto:[email protected]>


Subject: [PYSPARK] Python tests organization










Hi,





I can't help but wonder if there is any practical reason for keeping


monolithic test modules. These things are already pretty large (1500 -


2200 LOCs) and can only grow. Development aside, I assume that many


users use tests the same way as me, to check the intended behavior, and


largish loosely coupled modules make it harder than it should be.





If there's no rationale for that it could be a good time start thinking


about moving tests to packages and separating into modules reflecting


project structure.





--


Best,


Maciej








---------------------------------------------------------------------


To unsubscribe e-mail: 
[email protected]<mailto:[email protected]>







Reply via email to