+1 (non-binding) Checked all signatures/checksums for binaries and source, spot-checked maven artifacts. Thanks for fixing the signatures, Holden!
On Fri, Sep 29, 2017 at 8:25 AM, Holden Karau <hol...@pigscanfly.ca> wrote: > As a follow up the JIRA for this is at https://issues.apache.org/ > jira/browse/SPARK-22167 > > On Fri, Sep 29, 2017 at 2:50 AM, Holden Karau <hol...@pigscanfly.ca> > wrote: > >> This vote is canceled and will be replaced with an RC3 once Felix and I >> figure out the R packaging issue. >> >> On Fri, Sep 29, 2017 at 1:03 AM Felix Cheung <felixcheun...@hotmail.com> >> wrote: >> >>> -1 >>> >>> (Sorry) spark-2.1.2-bin-hadoop2.7.tgz is missing the R directory, not >>> sure why yet. >>> >>> Tested on multiple platform as source package, (against 2.1.1 jar) >>> seemed fine except this WARNING on R-devel >>> >>> * checking for code/documentation mismatches ... WARNING >>> Codoc mismatches from documentation object 'attach': >>> attach >>> Code: function(what, pos = 2L, name = deparse(substitute(what), >>> backtick = FALSE), warn.conflicts = TRUE) >>> Docs: function(what, pos = 2L, name = deparse(substitute(what)), >>> warn.conflicts = TRUE) >>> Mismatches in argument default values: >>> Name: 'name' Code: deparse(substitute(what), backtick = FALSE) Docs: >>> deparse(substitute(what)) >>> >>> Checked the latest release R 3.4.1 and the signature change wasn't >>> there. This likely indicated an upcoming change in the next R release that >>> could insur this new warning when we attempt to publish the package. >>> >>> Not sure what we can do now since we work with multiple versions of R >>> and they will have different signatures then. >>> ------------------------------ >>> *From:* Luciano Resende <luckbr1...@gmail.com> >>> *Sent:* Thursday, September 28, 2017 10:29:18 PM >>> *To:* Holden Karau >>> *Cc:* dev@spark.apache.org >>> >>> *Subject:* Re: [VOTE] Spark 2.1.2 (RC2) >>> +1 (non-binding) >>> >>> Minor comments: >>> The apache infra has a staging repository to add release candidates, and >>> it might be better/simpler to use that instead of home.a.o. See >>> https://dist.apache.org/repos/dist/dev/spark/. >>> >>> >>> >>> On Tue, Sep 26, 2017 at 9:47 PM, Holden Karau <hol...@pigscanfly.ca> >>> wrote: >>> >>>> Please vote on releasing the following candidate as Apache Spark >>>> version 2.1.2. The vote is open until Wednesday October 4th at 23:59 >>>> PST and passes if a majority of at least 3 +1 PMC votes are cast. >>>> >>>> [ ] +1 Release this package as Apache Spark 2.1.2 >>>> [ ] -1 Do not release this package because ... >>>> >>>> >>>> To learn more about Apache Spark, please see https://spark.apache.org/ >>>> >>>> The tag to be voted on is v2.1.2-rc2 >>>> <https://github.com/apache/spark/tree/v2.1.2-rc2> (fabbb7f59e47590 >>>> 114366d14e15fbbff8c88593c) >>>> >>>> List of JIRA tickets resolved in this release can be found with this >>>> filter. >>>> <https://issues.apache.org/jira/issues/?jql=project%20%3D%20SPARK%20AND%20fixVersion%20%3D%202.1.2> >>>> >>>> The release files, including signatures, digests, etc. can be found at: >>>> https://home.apache.org/~holden/spark-2.1.2-rc2-bin/ >>>> >>>> Release artifacts are signed with a key from: >>>> https://people.apache.org/~holden/holdens_keys.asc >>>> >>>> The staging repository for this release can be found at: >>>> https://repository.apache.org/content/repositories/orgapachespark-1251 >>>> >>>> The documentation corresponding to this release can be found at: >>>> https://people.apache.org/~holden/spark-2.1.2-rc2-docs/ >>>> >>>> >>>> *FAQ* >>>> >>>> *How can I help test this release?* >>>> >>>> If you are a Spark user, you can help us test this release by taking an >>>> existing Spark workload and running on this release candidate, then >>>> reporting any regressions. >>>> >>>> If you're working in PySpark you can set up a virtual env and install >>>> the current RC and see if anything important breaks, in the Java/Scala >>>> you can add the staging repository to your projects resolvers and test with >>>> the RC (make sure to clean up the artifact cache before/after so you >>>> don't end up building with a out of date RC going forward). >>>> >>>> *What should happen to JIRA tickets still targeting 2.1.2?* >>>> >>>> Committers should look at those and triage. Extremely important bug >>>> fixes, documentation, and API tweaks that impact compatibility should be >>>> worked on immediately. Everything else please retarget to 2.1.3. >>>> >>>> *But my bug isn't fixed!??!* >>>> >>>> In order to make timely releases, we will typically not hold the >>>> release unless the bug in question is a regression from 2.1.1. That >>>> being said if there is something which is a regression form 2.1.1 that >>>> has not been correctly targeted please ping a committer to help target the >>>> issue (you can see the open issues listed as impacting Spark 2.1.1 & 2 >>>> .1.2 >>>> <https://issues.apache.org/jira/browse/SPARK-21985?jql=project%20%3D%20SPARK%20AND%20status%20%3D%20OPEN%20AND%20(affectedVersion%20%3D%202.1.2%20OR%20affectedVersion%20%3D%202.1.1)> >>>> ) >>>> >>>> *What are the unresolved* issues targeted for 2.1.2 >>>> <https://issues.apache.org/jira/browse/SPARK-21985?jql=project%20%3D%20SPARK%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20%22Target%20Version%2Fs%22%20%3D%202.1.2> >>>> ? >>>> >>>> At this time there are no open unresolved issues. >>>> >>>> *Is there anything different about this release?* >>>> >>>> This is the first release in awhile not built on the AMPLAB Jenkins. >>>> This is good because it means future releases can more easily be built and >>>> signed securely (and I've been updating the documentation in >>>> https://github.com/apache/spark-website/pull/66 as I progress), >>>> however the chances of a mistake are higher with any change like this. If >>>> there something you normally take for granted as correct when checking a >>>> release, please double check this time :) >>>> >>>> *Should I be committing code to branch-2.1?* >>>> >>>> Thanks for asking! Please treat this stage in the RC process as "code >>>> freeze" so bug fixes only. If you're uncertain if something should be back >>>> ported please reach out. If you do commit to branch-2.1 please tag your >>>> JIRA issue fix version for 2.1.3 and if we cut another RC I'll move the >>>> 2.1.3 fixed into 2.1.2 as appropriate. >>>> >>>> *Why the longer voting window?* >>>> >>>> Since there is a large industry big data conference this week I figured >>>> I'd add a little bit of extra buffer time just to make sure everyone has a >>>> chance to take a look. >>>> >>>> -- >>>> Twitter: https://twitter.com/holdenkarau >>>> >>> >>> >>> >>> -- >>> Luciano Resende >>> http://twitter.com/lresende1975 >>> http://lresende.blogspot.com/ >>> >> -- >> Twitter: https://twitter.com/holdenkarau >> > > > > -- > Twitter: https://twitter.com/holdenkarau > -- Ryan Blue Software Engineer Netflix
