+1. So far, no function/performance regression in Spark SQL, Core and PySpark.
Thanks! Xiao 2018-02-19 19:47 GMT-08:00 Hyukjin Kwon <gurwls...@gmail.com>: > Ah, I see. For 1), I overlooked Felix's input here. I couldn't foresee > this when I added this documentation because it worked in my simple demo: > > https://spark-test.github.io/sparksqldoc/search.html?q=approx > https://spark-test.github.io/sparksqldoc/#approx_percentile > > Will try to investigate this shortly too. > > > > 2018-02-20 11:45 GMT+09:00 Shivaram Venkataraman < > shiva...@eecs.berkeley.edu>: > >> For (1) I think it has something to do with https://dist.apache.org/r >> epos/dist/dev/spark/v2.3.0-rc4-docs/_site/api/sql/ not automatically >> going to https://dist.apache.org/repos/dist/dev/spark/v2.3.0-rc4- >> docs/_site/api/sql/index.html -- So if you see the link to >> approx_percentile the link we generate is https://dist.apache.org/rep >> os/dist/dev/spark/v2.3.0-rc4-docs/_site/api/sql/#approx_percentile -- >> This doesn't work as Felix said but https://dist.apache.org/re >> pos/dist/dev/spark/v2.3.0-rc4-docs/_site/api/sql/index.html# >> approx_percentile works >> >> I'm not sure how this will behave on the main site. FWIW >> http://spark.apache.org/docs/latest/api/python/ does redirect to >> http://spark.apache.org/docs/latest/api/python/index.html >> >> Thanks >> Shivaram >> >> On Mon, Feb 19, 2018 at 6:31 PM, Felix Cheung <felixcheun...@hotmail.com> >> wrote: >> >>> Ah sorry I realize my wordings were unclear (not enough zzz or coffee) >>> >>> So to clarify, >>> 1) when searching for a word in the Sql function doc, it does return >>> that search result page correctly, however, none of the link in result >>> opens to the actual doc page, so to take the search I included as an >>> example, if you click on approx_percentile, for instance, it brings open >>> the web directory instead. >>> >>> 2) The second is the dist location we are voting on has a .iml file, >>> which is normally not included in release or release RC and it is unsigned >>> and without hash (therefore seems like it should not be in the release) >>> >>> Thanks! >>> >>> _____________________________ >>> From: Shivaram Venkataraman <shiva...@eecs.berkeley.edu> >>> Sent: Tuesday, February 20, 2018 2:24 AM >>> Subject: Re: [VOTE] Spark 2.3.0 (RC4) >>> To: Felix Cheung <felixcheun...@hotmail.com> >>> Cc: Sean Owen <sro...@gmail.com>, dev <dev@spark.apache.org> >>> >>> >>> >>> FWIW The search result link works for me >>> >>> Shivaram >>> >>> On Mon, Feb 19, 2018 at 6:21 PM, Felix Cheung <felixcheun...@hotmail.com >>> > wrote: >>> >>>> These are two separate things: >>>> >>>> Does the search result links work for you? >>>> >>>> The second is the dist location we are voting on has a .iml file. >>>> >>>> _____________________________ >>>> From: Sean Owen <sro...@gmail.com> >>>> Sent: Tuesday, February 20, 2018 2:19 AM >>>> Subject: Re: [VOTE] Spark 2.3.0 (RC4) >>>> To: Felix Cheung <felixcheun...@hotmail.com> >>>> Cc: dev <dev@spark.apache.org> >>>> >>>> >>>> >>>> Maybe I misunderstand, but I don't see any .iml file in the 4 results >>>> on that page? it looks reasonable. >>>> >>>> On Mon, Feb 19, 2018 at 8:02 PM Felix Cheung <felixcheun...@hotmail.com> >>>> wrote: >>>> >>>>> Any idea with sql func docs search result returning broken links as >>>>> below? >>>>> >>>>> *From:* Felix Cheung <felixcheun...@hotmail.com> >>>>> *Sent:* Sunday, February 18, 2018 10:05:22 AM >>>>> *To:* Sameer Agarwal; Sameer Agarwal >>>>> >>>>> *Cc:* dev >>>>> *Subject:* Re: [VOTE] Spark 2.3.0 (RC4) >>>>> Quick questions: >>>>> >>>>> is there search link for sql functions quite right? >>>>> https://dist.apache.org/repos/dist/dev/spark/v2.3.0-rc4-docs >>>>> /_site/api/sql/search.html?q=app >>>>> >>>>> this file shouldn't be included? https://dist.apache.org/repos/ >>>>> dist/dev/spark/v2.3.0-rc4-bin/spark-parent_2.11.iml >>>>> >>>>> >>>> >>>> >>> >>> >>> >> >
