Yep. That sounds good to me. On Tue, Nov 6, 2018 at 11:06 AM Sean Owen <sro...@gmail.com> wrote: > > Sounds good, remove in 3.1? I can update accordingly. > > On Tue, Nov 6, 2018, 10:46 AM Reynold Xin <r...@databricks.com wrote: >> >> Maybe deprecate and remove in next version? It is bad to just remove a >> method without deprecation notice. >> >> On Tue, Nov 6, 2018 at 5:44 AM Sean Owen <sro...@gmail.com> wrote: >>> >>> See https://github.com/apache/spark/pull/22921#discussion_r230568058 >>> >>> Methods like toDegrees, toRadians, approxCountDistinct were 'renamed' >>> in Spark 2.1: deprecated, and replaced with an identical method with >>> different name. However, these weren't actually deprecated in SparkR. >>> >>> Is it an oversight that we should just correct anyway by removing, to >>> stay synced? >>> Or deprecate and retain these in Spark 3.0.0? >>> >>> Sean >>> >>> --------------------------------------------------------------------- >>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >>>
--------------------------------------------------------------------- To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
