But it's true that imho there's less activity in SS in general. Should be noted. Maybe it's also because committers are busy for other stuffs.
Yea, I agree that one actionable strategy for now might be to make the PR description as clear as possible to make the review easier, and then ping them in the PRs. On Sun, 13 Jan 2019, 10:37 pm Sean Owen <sro...@gmail.com wrote: > Jungtaek, the best strategy is to find who wrote the code you are > modifying (use Github history or git blame) and ping them directly on > the PR. I don't know this code well myself. > It also helps if you can address why the functionality is important, > and describe compatibility implications. > > Most PRs are not merged, note. Not commenting on this particular one, > but it's not a 'bug' if it's not being merged. > > On Sun, Jan 13, 2019 at 12:29 AM Jungtaek Lim <kabh...@gmail.com> wrote: > > > > I'm sorry but let me remind this, as non-SS PRs are being reviewed > accordingly, whereas many of SS PRs (regardless of who create) are still > not reviewed and merged in time. > > > > 2019년 1월 3일 (목) 오전 7:57, Jungtaek Lim <kabh...@gmail.com>님이 작성: > >> > >> Spark devs, happy new year! > >> > >> I would like to remind this kindly, since there was actually no review > after initiating the thread. > >> > >> Thanks, > >> Jungtaek Lim (HeartSaVioR) > >> > >> 2018년 12월 12일 (수) 오후 11:12, Vaclav Kosar <ad...@vaclavkosar.com>님이 작성: > >>> > >>> I am also waiting for any finalization of my PR [3]. I seems that SS > PRs are not being reviewed much these days. > >>> > >>> [3] https://github.com/apache/spark/pull/21919 > >>> > >>> > >>> On 12. 12. 18 14:37, Dongjin Lee wrote: > >>> > >>> If it is possible, could you review my PR on Kafka's header > functionality[^1] also? It was added in Kafka 0.11.0.0 but still not > supported in Spark. > >>> > >>> Thanks, > >>> Dongjin > >>> > >>> [^1]: https://github.com/apache/spark/pull/22282 > >>> [^2]: https://issues.apache.org/jira/browse/KAFKA-4208 > >>> > >>> On Wed, Dec 12, 2018 at 6:43 PM Jungtaek Lim <kabh...@gmail.com> > wrote: > >>>> > >>>> Hi devs, > >>>> > >>>> Would I kindly ask for reviewing on PRs for Structured Streaming? I > have 5 open pull requests on SS side [1] (earliest PR was opened around 4 > months so far), and there looks like couple of PR for others [2] which > looks good to be reviewed, too. > >>>> > >>>> Thanks in advance, > >>>> Jungtaek Lim (HeartSaVioR) > >>>> > >>>> 1. > https://github.com/apache/spark/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+author%3AHeartSaVioR+%5BSS%5D > >>>> 2. > https://github.com/apache/spark/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+%5BSS%5D+ > >>>> > >>> > >>> > >>> -- > >>> Dongjin Lee > >>> > >>> A hitchhiker in the mathematical world. > >>> > >>> github: github.com/dongjinleekr > >>> linkedin: kr.linkedin.com/in/dongjinleekr > >>> speakerdeck: speakerdeck.com/dongjin > > --------------------------------------------------------------------- > To unsubscribe e-mail: dev-unsubscr...@spark.apache.org > >
