+1 as well On Tue, Jul 2, 2019 at 12:13 PM Dongjoon Hyun <dongjoon.h...@gmail.com> wrote:
> Thank you so much for the replies, Reynold, Sean, Takeshi, Hyukjin! > > Bests, > Dongjoon. > > On Mon, Jul 1, 2019 at 6:00 PM Hyukjin Kwon <gurwls...@gmail.com> wrote: > >> +1 >> >> 2019년 7월 2일 (화) 오전 9:39, Takeshi Yamamuro <linguin....@gmail.com>님이 작성: >> >>> I'm also using the script in both cases, anyway +1. >>> >>> On Tue, Jul 2, 2019 at 5:58 AM Sean Owen <sro...@gmail.com> wrote: >>> >>>> I'm using the merge script in both repos. I think that was the best >>>> practice? >>>> So, sure, I'm fine with disabling it. >>>> >>>> On Mon, Jul 1, 2019 at 3:53 PM Dongjoon Hyun <dongjoon.h...@gmail.com> >>>> wrote: >>>> > >>>> > Hi, Apache Spark PMC members and committers. >>>> > >>>> > We are using GitHub `Merge Button` in `spark-website` repository >>>> > because it's very convenient. >>>> > >>>> > 1. https://github.com/apache/spark-website/commits/asf-site >>>> > 2. https://github.com/apache/spark/commits/master >>>> > >>>> > In order to be consistent with our previous behavior, >>>> > can we disable `Allow Merge Commits` from GitHub `Merge Button` >>>> setting explicitly? >>>> > >>>> > I hope we can enforce it in both `spark-website` and `spark` >>>> repository consistently. >>>> > >>>> > Bests, >>>> > Dongjoon. >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >>>> >>>> >>> >>> -- >>> --- >>> Takeshi Yamamuro >>> >>