So I think using Worker everywhere would be a bit confusing since the relationship between worker and blockmanager replica is complex, also in the current PR `AgentLost` is not `WorkerLost` because it doesn't necessarily mean the worker is lost (there's a flag for if the worker has been lost).
On Thu, Jun 18, 2020 at 1:21 PM Matei Zaharia <matei.zaha...@gmail.com> wrote: > Yup, it would be great to do this. FWIW, I would propose using “worker” > everywhere instead unless it already means something in that context, just > to have a single word for this (instead of multiple words such as agent, > replica, etc), but I haven’t looked into whether that would make anything > confusing. > > On Jun 18, 2020, at 1:14 PM, Holden Karau <hol...@pigscanfly.ca> wrote: > > Thank you. I agree being careful with API comparability is important. I > think in situations where the terms are exposed in our API we can introduce > alternatives and deprecate the old ones to allow for a smooth migration. > > On Thu, Jun 18, 2020 at 12:28 PM Reynold Xin <r...@databricks.com> wrote: > >> Thanks for doing this. I think this is a great thing to do. >> >> But we gotta be careful with API compatibility. >> >> >> On Thu, Jun 18, 2020 at 11:32 AM, Holden Karau <hol...@pigscanfly.ca> >> wrote: >> >>> Hi Folks, >>> >>> I've started working on cleaning up the Spark code to remove references >>> to slave since the word has a lot of negative connotations and we can >>> generally replace it with more accurate/descriptive words in our code base. >>> The PR is at https://github.com/apache/spark/pull/28864 (I'm a little >>> uncertain on the place of where I chose the name "AgentLost" as the >>> replacement, suggestions welcome). >>> >>> At some point I think we should explore deprecating master as well, but >>> that is used very broadley inside of our code and in our APIs, so while it >>> is visible to more people changing it would be more work. I think having >>> consensus around removing slave though is a good first step. >>> >>> Cheers, >>> >>> Holden >>> >>> -- >>> Twitter: https://twitter.com/holdenkarau >>> Books (Learning Spark, High Performance Spark, etc.): >>> https://amzn.to/2MaRAG9 <https://amzn.to/2MaRAG9> >>> YouTube Live Streams: https://www.youtube.com/user/holdenkarau >>> >> >> -- > Twitter: https://twitter.com/holdenkarau > Books (Learning Spark, High Performance Spark, etc.): > https://amzn.to/2MaRAG9 <https://amzn.to/2MaRAG9> > YouTube Live Streams: https://www.youtube.com/user/holdenkarau > > > -- Twitter: https://twitter.com/holdenkarau Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 <https://amzn.to/2MaRAG9> YouTube Live Streams: https://www.youtube.com/user/holdenkarau
