Thanks for the great work, Hyukjin! On Wed, Apr 14, 2021 at 1:00 PM Gengliang Wang <ltn...@gmail.com> wrote:
> Thanks for the amazing work, Hyukjin! > I created a PR for trial and it looks well so far: > https://github.com/apache/spark/pull/32158 > > On Wed, Apr 14, 2021 at 12:47 PM Hyukjin Kwon <gurwls...@gmail.com> wrote: > >> Hi all, >> >> After https://github.com/apache/spark/pull/32092 merged, now we run the >> GitHub Actions >> workflows in your forked repository. >> >> In short, please see this example HyukjinKwon#34 >> <https://github.com/HyukjinKwon/spark/pull/34> >> >> 1. You create a PR and your repository triggers the workflow. Your PR >> uses the resources allocated to you for testing. >> 2. Apache Spark repository finds your workflow, and links it in a >> comment in your PR >> >> Please let me know if you guys find any weird behaviour related to this. >> >> >> *What does that mean to contributors?* >> >> Please sync your branch to the latest master branch in Apache Spark in >> order for your forked repository to run the workflow, and >> for the main repository to detect the workflow. >> >> >> *What does that mean to committers?* >> >> Now, GitHub Actions will show a green even when GitHub Actions builds are >> running (in contributor's forked repository). >> Please check the build notified by github-actions bot before merging it. >> There would be a followup work to reflect the status of the forked >> repository's build to the status of PR. >> >> 2021년 4월 14일 (수) 오후 1:42, Hyukjin Kwon <gurwls...@gmail.com>님이 작성: >> >>> Hi all, >>> >>> After https://github.com/apache/spark/pull/32092 merged, now we run the >>> GitHub Actions >>> workflows in your forked repository. >>> >>> In short, please see this example HyukjinKwon#34 >>> <https://github.com/HyukjinKwon/spark/pull/34> >>> >>> 1. You create a PR and your repository triggers the workflow. Your >>> PR uses the resources allocated to you for testing. >>> 2. Apache Spark repository finds your workflow, and links it in a >>> comment in your PR >>> >>> Please let me know if you guys find any weird behaviour related to this. >>> >>> >>> *What does that mean to contributors?* >>> >>> Please sync your branch to the latest master branch in Apache Spark in >>> order for the main repository to run the workflow and detect it. >>> >>> >>> *What does that mean to committers?* >>> >>> Now, GitHub Actions will show a green even when GitHub Actions builds >>> are running (in contributor's forked repository). Please check the build >>> notified by github-actions bot before merging it. >>> There would be a followup work to reflect the status of the forked >>> repository's build to >>> the status of PR. >>> >>> >>>
