Yeah, I think we can discuss and revert it (or fix it) per the veto set. Often problems are found later after codes are merged.
2021년 8월 20일 (금) 오전 4:08, Mridul Muralidharan <mri...@gmail.com>님이 작성: > Hi Holden, > > In the past, I have seen discussions on the merged pr to thrash out the > details. > Usually it would be clear whether to revert and reformulate the change or > concerns get addressed and possibly result in follow up work. > > This is usually helped by the fact that we typically are conservative and > don’t merge changes too quickly: giving folks sufficient time to review and > opine. > > Regards, > Mridul > > On Thu, Aug 19, 2021 at 1:36 PM Holden Karau <hol...@pigscanfly.ca> wrote: > >> Hi Y'all, >> >> This just recently came up but I'm not super sure on how we want to >> handle this in general. If code was committed under the lazy consensus >> model and then a committer or PMC -1s it post merge, what do we want to do? >> >> I know we had some previous discussion around -1s, but that was largely >> focused on pre-commit -1s. >> >> Cheers, >> >> Holden :) >> >> >> -- >> Twitter: https://twitter.com/holdenkarau >> Books (Learning Spark, High Performance Spark, etc.): >> https://amzn.to/2MaRAG9 <https://amzn.to/2MaRAG9> >> YouTube Live Streams: https://www.youtube.com/user/holdenkarau >> >
