+1 On Tue, Jun 10, 2025 at 11:40 AM Herman van Hovell <her...@databricks.com.invalid> wrote:
> +1 > > On Tue, Jun 10, 2025 at 2:04 PM Rozov, Vlad <vro...@amazon.com.invalid> > wrote: > >> +1 (non-binding) >> >> Thank you, >> >> Vlad >> >> On Jun 10, 2025, at 10:44 AM, Sakthi <sak...@apache.org> wrote: >> >> +1 (non-binding) >> >> On Mon, Jun 9, 2025 at 8:28 PM bo yang <bobyan...@gmail.com> wrote: >> >>> +1 (non-binding), thanks Martin! >>> >>> On Mon, Jun 9, 2025 at 7:47 PM Cheng Pan <pan3...@gmail.com> wrote: >>> >>>> +1 (non-binding) >>>> >>>> I verified: >>>> >>>> 1. LICENSE/NOTICE are present >>>> 2. Signatures is correct >>>> 3. Build source code and run UT (I have to replace sparksrc folder with >>>> the content of spark-4.0.0.tgz to make the source happen) >>>> >>>> Thanks, >>>> Cheng Pan >>>> >>>> >>>> >>>> On Jun 10, 2025, at 00:59, Martin Grund <mar...@databricks.com> wrote: >>>> >>>> Hi folks, >>>> >>>> Please vote on releasing the following candidate as Apache Spark >>>> Connect Go Client 0.1.0. >>>> >>>> The release candidate was tested and built against Spark 4.0.0. The >>>> repository contains a sample application for submitting jobs written in Go >>>> using a small JVM wrapper >>>> <https://github.com/apache/spark-connect-go/blob/master/java/README.md> >>>> and quickstart >>>> <https://github.com/apache/spark-connect-go/blob/master/quick-start.md> >>>> information. >>>> >>>> This vote is open for the next 72 hours and passes if a majority +1 PMC >>>> votes are cast, with a minimum of 3 +1 votes. >>>> >>>> [ ] +1 Release this package as Apache Spark Connect Go Client 0.1.0 >>>> [] -1 Do not release this package because ... >>>> >>>> Tag: https://github.com/apache/spark-connect-go/tree/v0.1.0-rc2 >>>> <https://github.com/apache/spark-connect-go/releases/tag/v0.1.0-rc2> >>>> (commit >>>> defb8525088150f9f328136a35fa7c5f64fe2733) >>>> >>>> The artifacts are available as well here: >>>> https://dist.apache.org/repos/dist/dev/spark/spark-connect-go-0.1.0-rc2/ >>>> >>>> The artifacts can be verified using the KEYS file >>>> https://dist.apache.org/repos/dist/dev/spark/KEYS >>>> >>>> I've addressed the comments above with regard to: >>>> >>>> - Build out of source tree >>>> - Signing using the dev KEYS file >>>> - Missing NOTICE file >>>> - Upload to the GitHub distribution >>>> >>>> Thanks >>>> Martin >>>> >>>> On Mon, Jun 9, 2025 at 8:54 AM Martin Grund <mar...@databricks.com> >>>> wrote: >>>> >>>>> Thanks for the feedback, I'll address it shortly. >>>>> >>>>> On Mon, Jun 9, 2025 at 08:31 Cheng Pan <pan3...@gmail.com> wrote: >>>>> >>>>>> Hi Martin, >>>>>> >>>>>> Thanks for addressing it, a few questions/issues I found: >>>>>> >>>>>> 1. The "fun Version"[1] returns "3.5.x”, this does not look like a >>>>>> correct version as you claim this release candidates was built and tested >>>>>> against Spark 4.0.0. >>>>>> >>>>>> 2. Seems your public key was not added to KEYS, so I can not verify >>>>>> your signature. >>>>>> >>>>>> $ wget https://downloads.apache.org/spark/KEYS >>>>>> $ gpg --import KEYS >>>>>> $ gpg --verify spark-connect-go-0.1.0-rc1.zip.asc >>>>>> gpg: assuming signed data in 'spark-connect-go-0.1.0-rc1.zip' >>>>>> gpg: Signature made Mon Jun 9 20:30:11 2025 CST >>>>>> gpg: using RSA key >>>>>> 4E3B5C29DD2CCCF97925469C1E0086A46C650707 >>>>>> gpg: Can't check signature: No public key >>>>>> >>>>>> 3. Though it’s not enforced, but so far all Spark release candidates >>>>>> were put at [2], instead of using GitHub release, I would recommend >>>>>> connect-go to follow that too. >>>>>> >>>>>> > Projects should use the /dev tree of the dist repository or the >>>>>> staging features of repository.apache.org to host release candidates >>>>>> posted for developer testing/voting (prior to being, potentially, >>>>>> formally >>>>>> blessed as a GA release). >>>>>> >>>>>> 4. The source releases are non-compilable because it does not contain >>>>>> the spark source code. To be clear, it[3] requires the "source release >>>>>> artifacts” MUST be sufficient for a user to build and test, not the git >>>>>> repo. >>>>>> >>>>>> Failure: directory "sparksrc/sql/connect/common/src/main/protobuf" >>>>>> listed in buf.work.yaml contains no .proto files >>>>>> exit status 1 >>>>>> make: *** [Makefile:69: internal/generated.out] Error 1 >>>>>> root@c072c654a72e:/go/spark-connect-go-0.1.0-rc1# ls >>>>>> sparksrc/sql/connect/common/src/main/protobuf >>>>>> ls: cannot access 'sparksrc/sql/connect/common/src/main/protobuf': No >>>>>> such file or directory >>>>>> >>>>>> 5. Missing NOTICE file [4] >>>>>> >>>>>> > Each package MUST provide a LICENSE file and a NOTICE file ... >>>>>> >>>>>> [1] >>>>>> https://github.com/apache/spark-connect-go/blob/v0.1.0-rc1/spark/version.go#L19 >>>>>> [2] https://dist.apache.org/repos/dist/dev/spark >>>>>> [3] https://www.apache.org/legal/release-policy.html#source-packages >>>>>> [4] >>>>>> https://www.apache.org/legal/release-policy.html#licensing-documentation >>>>>> >>>>>> Thanks, >>>>>> Cheng Pan >>>>>> >>>>>> >>>>>> >>>>>> On Jun 9, 2025, at 20:32, Martin Grund <mar...@databricks.com> wrote: >>>>>> >>>>>> I updated the release based on the tag with the source releases and >>>>>> the proper signature. >>>>>> >>>>>> https://github.com/apache/spark-connect-go/releases/tag/v0.1.0-rc1 >>>>>> >>>>>> On Sun, Jun 8, 2025 at 10:44 PM Cheng Pan <pan3...@gmail.com> wrote: >>>>>> >>>>>>> The release artifacts don’t satisfy the ASF release policy[1]. >>>>>>> >>>>>>> > Projects MUST direct outsiders towards official releases rather >>>>>>> than raw source repositories, nightly builds, snapshots, release >>>>>>> candidates, or any other similar packages. >>>>>>> >>>>>>> > Every ASF release MUST contain one or more source packages, which >>>>>>> MUST be sufficient for a user to build and test the release provided >>>>>>> they >>>>>>> have access to the appropriate platform and tools. A source release >>>>>>> SHOULD >>>>>>> not contain compiled code. >>>>>>> >>>>>>> [1] https://www.apache.org/legal/release-policy.html#publication >>>>>>> >>>>>>> Thanks, >>>>>>> Cheng Pan >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Jun 9, 2025, at 12:21, Martin Grund <mar...@databricks.com.INVALID> >>>>>>> wrote: >>>>>>> >>>>>>> Please vote on releasing the following candidate as Apache Spark >>>>>>> Connect Go Client 0.1.0. >>>>>>> >>>>>>> The release candidate was tested and built against Spark 4.0.0. The >>>>>>> repository contains a sample application for submitting jobs written in >>>>>>> Go >>>>>>> using a small JVM wrapper >>>>>>> <https://github.com/apache/spark-connect-go/blob/master/java/README.md> >>>>>>> and quickstart >>>>>>> <https://github.com/apache/spark-connect-go/blob/master/quick-start.md> >>>>>>> information. >>>>>>> >>>>>>> This vote is open for the next 72 hours and passes if a majority +1 >>>>>>> PMC votes are cast, with a minimum of 3 +1 votes. >>>>>>> >>>>>>> [ ] +1 Release this package as Apache Spark Connect Go Client 0.1.0 >>>>>>> [] -1 Do not release this package because ... >>>>>>> >>>>>>> Tag: https://github.com/apache/spark-connect-go/tree/v0.1.0-rc1 >>>>>>> (commit 2383413460105fbc665c7c36d7943d5f05a5b245) >>>>>>> >>>>>>> Thanks >>>>>>> Martin >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>> >>
