[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...

[aarondav]

Github user aarondav commented on the pull request:

    https://github.com/apache/incubator-spark/pull/582#issuecomment-34836430
  
    Thanks for looking into it! The situation sounds fine for the next minor 
release, and I don't think this patch needs to be included in the next 
maintenance release anyway (following your very own 
[suggestion](http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/browser)
 on the dev list).
    
    While this patch looks good to me, I am not sure I fully understand the 
need for it. I posted my question on the [dev list 
thread](http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/%3C945190638.685798.1391974088596.JavaMail.zimbra%40redhat.com%3E).
 Besides the dependency change, you also mention performance improvements. 
[This 
benchmark](http://engineering.ooyala.com/blog/comparing-scala-json-libraries) 
does show Jackson outperforming lift on a particular workload, but do you have 
another source showing how the relative performance changes with input size?