Github user markhamstra commented on the pull request:

    https://github.com/apache/incubator-spark/pull/468#discussion_r9777964
  
    Doesn't need to be `Iterable` itself, but only implicitly `Iterable` (as is 
`Option`).  In fact, what I believe Patrick was suggesting is that 
`tachyonStore` be made into an `Option` so that the common Scala idiom of 
`anOption.foreach(doSomethingIfSome(_))` can be used.  Even without changing 
the type of `tachyonStore`, a form of this idiom can be used anywhere `!= null` 
is used (but that's not a stylistic quirk that we've adopted consistently): 
`Option(tachyonStore).foreach(_.doSomething)`


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastruct...@apache.org or file a JIRA ticket with INFRA.

Reply via email to