Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/611#discussion_r9854034
Looks like if you did not use a sameThreadExecutor, it could execute
outside of the synchronization block, but I think you're right that we're
technically safe here. Still, I think it would be clearer and no less
performant to add an explicit synchronization to our functions, which also
allows us to ignore the implementation details of Curator.
This code path should be called so infrequently that we could probably
throw in a Thread.sleep(1000) and no one would notice...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastruct...@apache.org or file a JIRA ticket with INFRA.
---
