Github user mridulm commented on the pull request: https://github.com/apache/incubator-spark/pull/332#discussion_r9854094 While this makes sense (absence of connection in connectionsAwaitingSasl means server conn), how about matching it on type of Connection and throwing an error if client connection is not present in connectionsAwaitingSasl ? If I understood this right, it should not happen right now - but given how critical this codepath is for auth (incorrect in case we get security messages after we thought auth was done : which means something is wrong) would be better to guard it against future change which break this ?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---